Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define a msrv policy #525

Merged
merged 2 commits into from
Oct 17, 2024
Merged

define a msrv policy #525

merged 2 commits into from
Oct 17, 2024

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Oct 15, 2024

Like done in netavark,
containers/netavark#1098.

Signed-off-by: Paul Holzinger <[email protected]>
Ensure we can build our MSRV and delete the old ubuntu/centos task
instead that was often way to outdated.

Signed-off-by: Paul Holzinger <[email protected]>
Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99
Copy link
Member Author

Luap99 commented Oct 15, 2024

@baude @mheon PTAL

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@mheon
Copy link
Member

mheon commented Oct 15, 2024

LGTM

Copy link

Tests failed. @containers/packit-build please check.

@baude
Copy link
Member

baude commented Oct 17, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ee3a939 into containers:main Oct 17, 2024
33 of 44 checks passed
@Luap99 Luap99 deleted the msrv branch October 17, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants